[tsc-devel] Re: Was the Apple code removed from main.cpp?

datahead | Thu, 22 Oct 2015 08:56:31 UTC

Post via forum by datahead <…9@x…>:
[quote]The code that determined the resource path on Apple systems is probably
unnecessary anyway, because with the rework of the ResourceManager for
2.0.0 the data path is determined relative to the executable (or by
compilation option). I would expect that to work on Apple systems as
well, so I think that code can be removed anyway.[/quote]

If we have every reason to believe that Apple systems should be able to find the resources due to our ResourceManager changes, I think this makes sense.  I am not quite as familiar with this sub system, so I'll take your advice.

[quote]Fact is that TSC runs fine without it on non-Apple systems.[/quote]

[quote]You can always retrieve the code from Git’s history again, so there is
no loss in deleting it.[/quote]

I'd be a little cautious with this mindset, since cross platform support has always been one of our tenets.  We've already lost about 1 or 2 potential contributors due to a lack of Mac compilation support.  Visual Studio likewise could bring in new developers.  I realize, of course, that we will not have Visual Studio support for quite a while due to the technical issues we saw last time we tried.

It actually can be a little bit of trouble to find useful code in older versions of git history.  Most people will simply use the most recent version.  As I said above, I think it is fine to remove the code in this case, though.




-- 
Sent by Chessboard.